[Bug 193929] Review Request: knetstats

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knetstats


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929





------- Additional Comments From cgoorah at yahoo.com.au  2006-06-14 00:28 EST -------
------- Additional Comments From j.w.r.degoede hhs nl  2006-06-12 02:22 EST -------
(In reply to comment #12)
> Re: comment #10
> > -update-desktop-database is deprecated
>
> It certainly is not deprecated (what makes you say that?).
>

Sorry, deprected in deed is the wrong way to formulate this, what I meant is
usually calling update-desktop-database is no longer needed unless:

> the app's .desktop file contains MimeType= entries, ScriptletSnippets are
> clear that use of update-desktop-database in %post/%postun is required.

---

(In reply to comment #13)
> (In reply to comment #12)
> > Re: comment #10
> > > -update-desktop-database is deprecated
> >
> > It certainly is not deprecated (what makes you say that?).
>
> Hans, you want to comment on this ?
>

See above, the knetstats does not contain any MimeType's, so the call to
update-desktop-database should be removed (and the Requires).

> Anyone want to sponsor me for knetstats ? Hans ?
>

Quoting myself from comment #6:

I see (from google) that you're already active in other area's of the Fedora
project, good! As such I'm willing to sponsor you, but first you must show some
more / better understanding of the FE packaging guidelines.

There are 2 ways to show this better understanding:
1) You review a couple of packages from others see FE-NEW for a list of
  Review Requests that need a Reviewer, don't worry about not being competent
  enough todo a review, just add me to the CC-list and I'll watch over your
  back.
2) Create some more packages and put me in the CC for the Review Request

So yes, I'm willing to sponsor you (eventually) provided that you show a
somewhat better understanding of the packaging guidelines then you've done
sofar. (Sofar is ok, you're still learning I understand!).

So lets first get this package approved (but not yet imported as your not
sponsored), and then I think it would be a good idea for you to package
something else (maybe you already have) and get that reviewed too, usually after
2 packages most people are beginning to understand the guidelines good enough to
get sponsored (good enough for my taste atleast).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.