[Bug 189884] Review Request: LASH Audio Session Handler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LASH Audio Session Handler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189884


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|seg at haxxed.com              |j.w.r.degoede at hhs.nl
                 CC|                            |nando at ccrma.stanford.edu
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-15 07:38 EST -------
I'm sponsering Nando from CCNRMA and attempting to help him to get a bit upto
steam, since one of his packages needs fluidsynth which in turn needs this one
I'm reviewing this one. Callum I hope you don't mind.

MUST:
=====
0 rpmlint output is:
W: lash incoherent-version-in-changelog 0.4.0-2 0.5.1-2
W: lash devel-file-in-non-devel-package /usr/lib/pkgconfig/lash-1.0.pc
E: lash zero-length /usr/share/doc/lash-0.5.1/docs/html-manual-stamp
E: lash postin-without-ldconfig /usr/lib/liblash.so.2.0.0
E: lash library-without-ldconfig-postun /usr/lib/liblash.so.2.0.0
E: lash zero-length /usr/share/doc/lash-0.5.1/docs/texinfo.tex
W: lash-devel no-documentation
These all must be fixed except for the last Warning which can be ignored
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
0 BR: ok (see below)
* No locales
0 shared libraries but no ldconfig, see MUST fix (and rpmlint output).
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
0 -devel as needed, .pc file must be moved to -devel
0 gui .desktop files required Fix please.


MUST fix:
=========
* the following rpmlint output:
W: lash incoherent-version-in-changelog 0.4.0-2 0.5.1-2
W: lash devel-file-in-non-devel-package /usr/lib/pkgconfig/lash-1.0.pc
E: lash zero-length /usr/share/doc/lash-0.5.1/docs/html-manual-stamp
E: lash postin-without-ldconfig /usr/lib/liblash.so.2.0.0
E: lash library-without-ldconfig-postun /usr/lib/liblash.so.2.0.0
E: lash zero-length /usr/share/doc/lash-0.5.1/docs/texinfo.tex
* Redundant BuildRequires: libtermcap-devel (already implied by readline-devel
  Please remove the libtermcap-devel BR.
* This can't be right can it? :
 BuildRequires: gtk+-devel, gtk2-devel
 Usually a package uses either gtk+ (gtk1) or gtk2, not both.
 Judging from the rpm -q --requires lash output it uses gtk2 and thus gtk+-devel
 can be dropped.
* Lash contains gtk apps which are gui apps and should properly install
 .desktop files for this, see:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
 for info on howto properly install .desktop files.
* The lash_XXpx.png icons are installed /usr/share/lash/icons that is not
  according to the freedesktop.org icon standard, it should go under:
  %{_datadir}/icons/hicolor/32x32/apps
  Where 32x32 is the size of the icon, the ixons then should be named just 
  lash.png (not lash_XXpx.png. Please do ls /usr/share/icons/hicolor/
  to see the available valid sizes, if the icon doesn't match any pick the 
  closest. I think lash doesn't use the other format icons in that case they
  should be dropped in %doc and the /usr/share/lash/icons dir should be removed
  (or atleast not packaged).
* Once the icon is in the proper case you must add %post(un) script to update 
  the icon-cache see:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
* The dtd file should be installed under /usr/share/xml/lash/dtds instead of
 under /usr/share/lash/dtds. Notice that after these changes there is no more
 use of /usr/share/lash needed!
* The: "Requires: jack-audio-connection-kit-devel alsa-lib-devel"
 for the devel package should be above %description, now its part of the
 description:
[hans at guest-dhcp-048 ~]$ rpm -qi lash-devel
Name        : lash-devel                   Relocations: (not relocatable)
Version     : 0.5.1                             Vendor: (none)
Release     : 2                             Build Date: Thu 15 Jun 2006 12:26:42
PM CEST
Install Date: Thu 15 Jun 2006 12:31:44 PM CEST      Build Host:
guest-dhcp-048.si.hhs.nl
Group       : Development/Libraries         Source RPM: lash-0.5.1-2.src.rpm
Size        : 25430                            License: GPL
Signature   : (none)
URL         : http://www.nongnu.org/lash/
Summary     : Development files for LASH
Description :
Development files for the LASH library.
Requires: jack-audio-connection-kit-devel alsa-lib-devel
[hans at guest-dhcp-048 ~]$
 

Should fix:
===========
* Please use %{version} in Source0 this makes life easier for yourself when you 
  want to upgrade to a newer upstream version.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.