[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |j.w.r.degoede at hhs.nl
                 CC|                            |nando at ccrma.stanford.edu
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-15 07:47 EST -------
MUST:
=====
0 rpmlint output is:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
These both must be fixed.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
0 License (LGPL) ok, but license file not included!
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* shared libraries, ldconfig properly ran
* Not relocatable
* Package owns / or requires all dirs (with some strangeness see Must fix below)
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
0 no %doc
* -devel package as needed
0 .la files packaged, bad!
* no gui -> no .desktop file required


MUST fix:
=========
* Alphanumeric parts of the version should be in the Release field, as per:
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines
 Then you can drop the "-n fluidsynth-1.0.7" to %setup too
* Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora
  package use %package libs same goes for the devel package.
* The following rpmlint output:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
* Don't package .la files, remove them under %install or %exclude them in %files
* Add a %doc including atleast COPYING, but mosty likely also other candidates


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.