[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-15 08:18 EST -------
MUST:
=====
* rpmlint output is:
W: qsynth no-version-in-last-changelog
W: qsynth-debuginfo no-version-in-last-changelog
These both must be fixed.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* .desktop file as required and properly installed

MUST fix:
=========
* rpmlint output is:
W: qsynth no-version-in-last-changelog
W: qsynth-debuginfo no-version-in-last-changelog
These both must be fixed.
* Source0: http://dl.sf.net/qsynth/qsynth-%{version}.tar.gz
 Must be: Source0: http://dl.sf.net/sourceforge/qsynth/qsynth-%{version}.tar.gz
* %makeinstall is broken (yeah I know, someone should fix it) please use:
  make install DESTDIR=$RPM_BUILD_ROOT instead. (Or make that %{__make} ......)
* Under %files I see %{_datadir}/icons/qsynth.png, that is not according to the
  freedesktop.org icon standard, it should go under:
  %{_datadir}/icons/hicolor/32x32/apps
  Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/
  to see the available valid sizes, if the icon doesn't match any pick the 
  closest.
* Once the icon is in the proper case you must add %post(un) script to update 
  the icon-cache see:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.