[Bug 194612] Review Request: pstoedit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pstoedit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194612





------- Additional Comments From pertusus at free.fr  2006-06-15 10:47 EST -------
Indeed they seem to qualify as internal dlopened libraries. It is 
somehow strange that upstream don't simply link them, it would be
cleaner, but it isn't really problematic. That was the last issue
I found, so now for the formal review:

* rpmlint is silent
* follow naming guidelines
* licence is GPL and included
* source match upstream 13f24cb070da3f6af82ed84f4e53f049
* build on FC5
* buildrequires seem right, although I haven't built in mock
* ldconfig is run
* creates the directory it owns, except /usr/share/aclocal/. Not a
  big deal, in my opinion, as there are other packages that do that.
  I am not sure but it seems that there were some discussions about
  that, but I can't recall the result. I don't consider that a blocker
  but you may want to raise the issue on the extras list
* things in -devel are right. There are .so in the main package, 
  but these are dlopened libraries

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.