[Bug 191200] Review Request: lvm2-cluster

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lvm2-cluster


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191200





------- Additional Comments From jkeating at redhat.com  2006-06-15 14:53 EST -------
ooops, that was gfs-cluster I think.  I was wrong, here is the missing comments:

On Tue, Jun 13, 2006 at 06:54:20PM -0400, Jesse Keating wrote:
> rpmlint is unhappy:
 
# yum install rpmlint
# man rpmlint
No manual entry for rpmlint

So the rpmlint package itself needs fixing to include a man page for
a binary it installed!  Hardly instills confidence.
/usr/share/doc has nothing useful for it either.

> E: lvm2-cluster non-standard-executable-perm /usr/sbin/clvmd 0555

What's rpmlint complaining about?  It's got the executable bits and it can't be
written to by a non-root user.  Some would argue 0111 would be better, but this
is a distribution so there's little to gain from a security-by-obscurity
argument as it's trivial for a user to get hold of a copy of the binary from
elsewhere.

- Ignoring.  (rpmlint bug?)

> E: lvm2-cluster postin-without-ldconfig /usr/lib/liblvm2clusterlock.so.2.02
> E: lvm2-cluster library-without-ldconfig-postun
/usr/lib/liblvm2clusterlock.so.2.02

OK: the packaging installation process doesn't run ldconfig automatically yet
so it has to be included in every spec file that handles shared libraries.

However, other packages look to have '%postun -p /sbin/ldconfig' and I've
googled and searched the Fedora wiki and the new online book you mentioned, but
as usual, I can't find documentation for what I need to know, viz. what '-p'
does and whether you're meant to use it if there are other commands to run in
the same section.

For safety, opted for:
  %post
  /sbin/chkconfig --add clvmd
  /sbin/ldconfig
 
  %postun -p /sbin/ldconfig

> E: lvm2-cluster non-standard-executable-perm
/usr/lib/liblvm2clusterlock.so.2.02 0555

Puzzling: I thought linux wanted both the read and execute bits to be set these days
on shared objects, not just the read bit (which is all that's required at the kernel
level).

- Ignoring.  (rpmlint bug?)

> W: lvm2-cluster devel-file-in-non-devel-package /usr/lib/liblvm2clusterlock.so

Seems overkill to create a lvm2-cluster-devel package containing just 
one symlink?  I don't spot other packages with shared libraries doing 
that.

- Ignoring.

> W: lvm2-cluster no-reload-entry /etc/rc.d/init.d/clvmd

The daemon doesn't support 'reload', so it would be misleading
to offer that option in the script.  Or should it give a message
saying 'unsupported'?  But I don't see other scripts doing that:
they're just silent. (e.g. mailman, spamassassin, mysqld, haldaemon).

> W: lvm2-cluster service-default-enabled /etc/rc.d/init.d/clvmd

The RHEL4->Fedora patch got dropped from the RPM.  Fixing.

> W: lvm2-cluster incoherent-init-script-name clvmd

Calling the init script 'lvm2-cluster' or renaming the package to 'clvmd' will
surely only confuse people more?

- Ignoring.

> W: lvm2-cluster-debuginfo dangling-relative-symlink
/usr/src/debug/LVM2.2.02.06/include/lvm-types.h ../lib/datastruct/lvm-types.h
> W: lvm2-cluster-debuginfo dangling-relative-symlink
/usr/src/debug/LVM2.2.02.06/include/log.h ../lib/log/log.h
> W: lvm2-cluster-debuginfo dangling-relative-symlink
/usr/src/debug/LVM2.2.02.06/include/list.h ../lib/datastruct/list.h

I've never done anything with debuginfo packages before.
Is this a bug in whatever bit of rpm generates them?

I've installed the 'lvm2' debuginfo package, and it has a similar problem.

I don't understand enough about how debuginfo packages are used to know whether
the problem is the symlink that shouldn't be there, or if it's the file at the 
end of it that shouldn't be missing.

On Wed, Jun 14, 2006 at 02:27:07PM -0400, Jesse Keating wrote:
> A standard executable should have permission set to 0755. If you get
> this
> message, it means that you have a wrong executable permissions in some
> files
> included in your package.
 
Oh!  So it prefers the owner of the executable to have write permission.
The file is owned by root so owner write is irrelevant, but it's better not
to set it IMHO as that gives out the wrong message, suggesting it's a file
other applications might want to modify: for example, editors will often warn 
the file is read-only if you try to modify it even as root.

I think that 'Error' from rpmlint should be downgraded to 'information', and
it should be inverted - warning if the owner write bit is *set* on an
executable.

> >   %postun -p /sbin/ldconfig
> All I know of -p is that it automatically figures out what the
> Requires(postun) would need.

Ah.  Does it work split line I wonder?

  %postun -p
  /sbin/ldconfig
 

> That's why its just a warning.  Although 'clvmd' is rather cryptic.

Would have been nice to have had a better name for it.
 
> Thanks, can you incorporate some of the above changes?

The ones I mentioned in the email I'd already put into lvm2-cluster-2_02_06-1_2.

Probably still missing the requires for ldconfig though.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.