[Bug 195292] Review Request: Openbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Openbox


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195292





------- Additional Comments From kaboom at oobleck.net  2006-06-15 16:20 EST -------
Musts:

- rpmlint has two complaints:

$ rpmlint SRPMS/openbox-3.3-0.3.rc2.src.rpm 
W: openbox strange-permission openbox.desktop 0775
$ rpmlint RPMS/i386/openbox-*
E: openbox script-without-shellbang /usr/share/xsessions/openbox.desktop

the SRPM one is valid -- openbox.desktop doesn't need be executable in the
source tree and doesn't appear to need to be executable even when installed (gdm
still works with that session with it set to 0644)

the script-without-shellbang appears to be bogus

+ package name is fine
+ spec file name is fine
+ package meets packaging guidelines
+ license is open source
+ license is correct
+ license is included
+ spec is English
+ spec is legible

it could be simpler if the conditionalized epoch stuff were left out for the
-devel package, if the version macroization were calmed down (the package
releases every two years, so updating versions isn't that big a deal ;-), and if
the x requires stuff weren't conditionalized since you'll have separate specs in
each branch anyway. Not a big deal though

+ source matches upstream

$ md5sum openbox-3.3-rc2.tar.gz ../SOURCES/openbox-3.3-rc2.tar.gz
1ff100d27cc1f47dadebb884a696dac3  openbox-3.3-rc2.tar.gz
1ff100d27cc1f47dadebb884a696dac3  ../SOURCES/openbox-3.3-rc2.tar.gz
$

+ package builds
+ no archs excluded
+ BuildRequires complete
+ locales dealt with
+ shared libraries dealt with

- package dir ownership is broken for the theme files:

/usr/share/themes/Allegro/openbox-3/bullet.xbm
/usr/share/themes/Allegro/openbox-3/themerc
/usr/share/themes/Artwiz/openbox-3/themerc
/usr/share/themes/Blah41/openbox-3/themerc
/usr/share/themes/Om4Ob/openbox-3/close.xbm
/usr/share/themes/Om4Ob/openbox-3/close_hover.xbm
/usr/share/themes/Om4Ob/openbox-3/desk.xbm
/usr/share/themes/Om4Ob/openbox-3/desk_hover.xbm
/usr/share/themes/Om4Ob/openbox-3/desk_toggled.xbm
/usr/share/themes/Om4Ob/openbox-3/iconify.xbm
/usr/share/themes/Om4Ob/openbox-3/iconify_hover.xbm
/usr/share/themes/Om4Ob/openbox-3/iconify_pressed.xbm
/usr/share/themes/Om4Ob/openbox-3/max.xbm
/usr/share/themes/Om4Ob/openbox-3/max_disabled.xbm
/usr/share/themes/Om4Ob/openbox-3/max_hover.xbm
/usr/share/themes/Om4Ob/openbox-3/max_pressed.xbm
/usr/share/themes/Om4Ob/openbox-3/max_toggled.xbm
/usr/share/themes/Om4Ob/openbox-3/shade.xbm
/usr/share/themes/Om4Ob/openbox-3/shade_disabled.xbm
/usr/share/themes/Om4Ob/openbox-3/shade_hover.xbm
/usr/share/themes/Om4Ob/openbox-3/shade_toggled.xbm
/usr/share/themes/Om4Ob/openbox-3/themerc
/usr/share/themes/TheBear/openbox-3/themerc

needs to own Allegro, Artwiz, etc and openbox-3 dirs

+ no duplicated files

- permissions need fixing for openbox.desktop in SRPM and possibly in RPM

+ %clean fine
+ macros fine
+ package is code
+ no large docs
+ no inappropriate %doc
+ headers in -devel
+ .pc in -devel
+ correct library split between base and -devel
+ devel require of base is correct
+ .la excluded
+ no Gnome desktop-file needed
+ doesn't incorrectly own dirs

Shoulds:

+ builds in mock
+ software works


Looks pretty good -- only changes required are fixing theme file directory
ownership and the permissions on the desktop file

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.