[Bug 177580] Review Request: lat (LDAP Administration Tool)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lat  (LDAP Administration Tool)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177580





------- Additional Comments From paul at city-fan.org  2006-06-16 16:47 EST -------
(In reply to comment #32)
> I'm not sure that:
> - Use %%{_prefix}/lib rather than %%{_libdir}, needed for 64-bit builds
> 
> Is the proper fix, this might work for lat, because its ./configure appearantly
> ignores %libdir, but it won't work for other noarch mono packages, I believe the
> libdir hack is the "correct" solution for this. Yes in combination with noarch
> and the %target hack, ain't mono fun to package?

I suspect that many mono packages will completely ignore libdir. To test this
hypothesis, I tried making these changes to PFJ's gtksourceview-sharp package
(Bug #178901):

$ diff -u gtksourceview-sharp.spec.orig gtksourceview-sharp.spec
--- gtksourceview-sharp.spec.orig       2006-06-16 21:28:20.000000000 +0100
+++ gtksourceview-sharp.spec    2006-06-16 21:38:07.000000000 +0100
@@ -1,5 +1,5 @@
 %define extra 0.10
-%define debug_package %{nil}
+#define debug_package %{nil}

 Summary: A C sharp binder for gtksourceview
 Name: gtksourceview-sharp
@@ -11,9 +11,16 @@
 URL: http://go-mono.com/sources/%{name}-%{version}/
 Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: mono-data, mono-devel, gtk-sharp2, gtksourceview-devel,
gtk-sharp2-gapi, gecko-sharp2, pkgconfig
+BuildRequires: which
 Requires: mono-core, gtksourceview
 BuildArch: noarch

+# Horrible, horrible, mono hacks
+%define _target_platform sparc86x-%{_vendor}-%{_target_os}%{?_gnu}
+%define monolibdir %{_prefix}/lib
+# To see if any attention is paid to %_libdir
+%define _libdir /opt/lib
+
 %description
 gtksourceview-sharp is a C sharp binder for gtksourceview

@@ -31,7 +38,7 @@

 %build
 export MONO_SHARED_DIR=%{_builddir}/%{?buildsubdir}
-%configure --target=sparc86x
+%configure
 make %{?_smp_mflags}

 %install
@@ -45,12 +52,12 @@
 %doc AUTHORS COPYING INSTALL NEWS README
 %{_datadir}/gapi-2.0/gtksourceview-api.xml
 %{_datadir}/gtksourceview-1.0/language-specs/nemerle.lang
-%{_libdir}/mono/gac/gtksourceview-sharp/*
-%{_libdir}/mono/gtksourceview-sharp-2.0/gtksourceview-sharp.dll
+%{monolibdir}/mono/gac/gtksourceview-sharp/*
+%{monolibdir}/mono/gtksourceview-sharp-2.0/gtksourceview-sharp.dll

 %files devel
 %defattr (-,root,root,-)
-%{_libdir}/pkgconfig/gtksourceview-sharp-2.0.pc
+%{monolibdir}/pkgconfig/gtksourceview-sharp-2.0.pc

 %clean
 %{__rm} -rf %{buildroot}


It built OK for me on i386, and since it ignored my change of libdir to
/opt/lib, I believe it would build on x86_64 too. Obviously this is too small a
sample to use as a basis for setting general guidelines, but it does indicate
that lat is not alone in ignoring libdir.

I think that changing libdir is a more horrible hack that what I've done, and
I'd prefer to keep the horribleness level down as low as possible :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.