[Bug 195645] Review Request: rasqal - RDF query library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rasqal - RDF query library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195645





------- Additional Comments From thomas at apestaart.org  2006-06-18 16:14 EST -------
It's not that I do not want to use %makeinstall - it's that the packaging
guidelines that mention you shouldn't use it do not say *anything* useful about
it, why it's bad, and they're not even correct.   If I need to make this change,
I need to know because I have a bunch of other packages using %makeinstall.

Let's take those rules step by step:

      %makeinstall overrides a set of environment variables during "make
install". I.e. it performs make prefix="..." includedir="..." ...

This is wrong - it overrides make variables, not environment variables.  There's
a difference between

prefix= make install

and

make prefix= install

In addition, this is all the rule says - it does not say that it is wrong or why
it is wrong.  So it's a) factually wrong and b) irrelevant.


      It is error prone, and can have unexpected effects when run against less
than perfect Makefiles.

How is it error prone ? How does make DESTDIR=... not fail when run against a
less than perfect Makefile - for example, one that doesn't even *have* DESTDIR ?

      It can trigger unnecessary rebuilds when executing "make install"

Don't know about this one, it may be true or may not be true, but in all the
packages I've built I've never known this to be a problem that actually bothered me.

      If a package contains libtool archives, it can cause broken *.la files to
be installed.

I haven't seen broken .la files, and it's not relevant - we do not ship .la
files, we delete them from every package.

If you want, I'll discuss it more directly with spot.  There may be actual good
reasons against makeinstall, but whatever they are, the ones in the wiki aren't
those.

I've searched through my local archives for any mails that could be related to
this, and didn't find anything straight away - though the lists are big, so I
may have missed them.  Do you have a link to the thread where this was discussed ?

Thanks
Thomas

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.