[Bug 185951] Review Request: amsn : msn messenger clone

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: amsn : msn messenger clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951





------- Additional Comments From wart at kobold.org  2006-06-18 18:54 EST -------
MUST
====
* rpmlint output:
  W: amsn-plugins no-documentation

* Package named appropriately
* GPL license ok, license file included
* Spec file legible
* compiles and packages on FC5 i386 and FC5 x86_64.
* No language files in %{_datadir}/locale, no need for %find_lang
  All translations are stored in %{_datadir}/%{name}/lang
* No shared libs in the default linker path
* Not relocatable
* File permissions look ok.
* $RPM_BUILD_ROOT cleaned where needed.
* Contains code, not content
* Not enough docs to warrant a -doc subpackage
* No reason for a -devel subpackage (no headers, libs, pkgconfig files)
* Does not own directories owned by other packages

MUSTFIX
=======
* Version comparison for tk-devel is not necessary since FC4 and later all
  use tk 8.4.
* The URL in %description isn't necessary since it's already in the URL:
  tag.
* Remove the Version: tag from the plugins subpackage so that it inherits
  the full %{version}-%{release} from the base package.  Otherwise you run
  the risk of building a second, slightly different plugins subpackage later
  that has the same version.
* The 48x48 icon for the .desktop file should go in
  ${RPM_BUILD_ROOT}%{_datadir}/icons/hicolor/48x48/apps/
  and you need to update the icon cache in both %post and %postun:

  touch --no-create %{_datadir}/icons/hicolor || :
  if [ -x %{_bindir}/gtk-update-icon-cache ]; then
     %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
  fi
* Missing BuildRequires: autoconf
* BuildRequires: libXt-devel is redundant since it's also required by tk-devel.
* The binaries are installed into /usr/share/amsn/ and linked into /usr/bin.
* There are a number of duplicate files in %{_datadir}/amsn and %doc:
  AGREEMENT, CREDITS, ... These should be removed from %{_datadir}/amsn.
* amsn/lang/LANG-HOWTO should be included in %doc
* The desktop file is placed in %{_datadir}/applications and %{_datadir}/amsn.
  Remove the extra copy in %{_datadir}/amsn since it's not needed there.
* Missing "Requires: mozilla".  I would recommend, however, changing the
  default browser command from 'mozilla $url' to 'htmlview $url' and
  adding "Requires: htmlview".  This will launch the url in the
  user's preferred web browser.
* Missing "Requires: sox" for /usr/bin/play for playing sounds.
* As pointed out above, be consistent about $RPM_BUILD_ROOT vs.
  ${RPM_BUILD_ROOT}
* The %description for the -plugins subpackage doesn't need to include the
  full description for the base package.  Just describe the purpose
  of the subpackage, such as "Extra plugins for amsn to enable foo, bar,
  and baz."

QUESTIONS
=========
* Official upstream sources come from sourceforge.net, but this rc release
  comes from elsewhere.  Since I know you're one of the upstream developers,
  I'm not too concerned about this, but it would be better if Source0:
  pointed to upstream's official download page.

* You might consider submitting cximage as a separate package instead of
  including it in amsn.  Since Fedora doesn't include cximage already,
  this won't block the review.

* Is there a special reason why the amsn commands (amsn, amsn-remote,
  amsn-remote-CLI) are located in %{_datadir}/amsn and only linked to
  %{_bindir}?  Why can't they just be installed directly into %{_bindir}?

* Is it necessary to include the %{_datadir}/amsn/lang/missing.py, convert.tcl,
  and sortlang utilities in the package?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.