[Bug 195871] Review Request: obmenu
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jun 19 05:29:24 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: obmenu
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195871
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|bugzilla-sink at leemhuis.info |panemade at gmail.com
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From panemade at gmail.com 2006-06-19 01:21 EST -------
Review for this package:-
Mock Build Results for i386
- Successfully built for i386
MUST Items:
- MUST: rpmlint shows no error
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package obmenu, in the format
obmenu.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license GPL.
- MUST: The License field in the package obmenu.spec file matches the
actual license file COPYING in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains %{__rm} -rf
%{buildroot}.
- MUST: This package used macros.
- MUST: Document files are included like README.
This package also followed optimized .pyo files installation successfully.
You should follow Python Packaging Guidelines for installing module in
pythin_sitelib as
%files
%defattr(-,root,root,-)
%dir %{python_sitelib}/modulename
%{python_sitelib}/modulename/*.py
%{python_sitelib}/modulename/*.pyc
You have not included/created separate directory for your module.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list