[Bug 189884] Review Request: LASH Audio Session Handler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LASH Audio Session Handler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189884





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-21 03:43 EST -------
Much better unfortunatly there is one new blocker

MUST fix:
-Under %files it currently says: "%{_datadir}/xml/lash/dtds"
That should be: "%{_datadir}/xml/lash" otherwise that dir is unowned.
-update-desktop-database is only needed when a .desktop file which defines a
 mimetype is installed, that doesn't happen here so please remove the calling
 of update-desktop-database from %post(un)
-and also remove because of the above change:
Requires(post):   desktop-file-utils
Requires(postun): desktop-file-utils

About using %version in Source0 either way is fine it was just an advice, people
who want it to be directly wget-able should learn to use "spectool -g bla.spec"
which will expand the macros, do the copy paste and wget call for them.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.