[Bug 196120] Review Request: gresistor
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 22 10:02:12 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gresistor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196120
------- Additional Comments From panemade at gmail.com 2006-06-22 05:54 EST -------
Not an official review as I'm not yet sponsored
Mock build for i386 development gave
/var/tmp/gresistor-0.0.1-2.fc6-root-mockbuild/usr/share/applications/gresistor.desktop:
key "Categories" string list not semicolon-terminated, fixing
You Need to add semicolon at end of Categories string list
MUST Items:
- MUST: rpmlint shows no error
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package gresistor, in the
format gresistor.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license GPL.
- MUST: The License field in the package gresistor.spec file did NOT match
any file in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package did NOT owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like README.
- MUST: This Package include a gresistor.desktop file, and that file is
installed with desktop-file-install in the %install section successfully.
- MUST: Package is calling ldconfig on postun post successfully.
* Source URL is present.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
* Able to see Desktop icon along with its icon
You need to
* Add license file in tarball
* Make package belong to /usr/share/gresistor under %files as
%dir %{python_sitelib}/gresistor
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list