[Bug 192958] Review Request: ejabberd - A distributed, fault-tolerant Jabber/XMPP server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ejabberd - A distributed, fault-tolerant Jabber/XMPP server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192958





------- Additional Comments From tibbs at math.uh.edu  2006-06-22 16:06 EST -------
I ended up having to redo my mock setup last night, but everything's working
fine today.  The package builds fine on x86_64, development.  Here's what
rpmlint has to say:

W: ejabberd no-soname /usr/lib64/ejabberd-1.1.1/priv/lib/expat_erl.so
W: ejabberd no-soname /usr/lib64/ejabberd-1.1.1/priv/lib/iconv_erl.so
W: ejabberd no-soname /usr/lib64/ejabberd-1.1.1/priv/lib/stringprep_drv.so
W: ejabberd no-soname /usr/lib64/ejabberd-1.1.1/priv/lib/ejabberd_zlib_drv.so
W: ejabberd no-soname /usr/lib64/ejabberd-1.1.1/priv/lib/tls_drv.so
I'll accept these as meaningless for private internal libraries.

E: ejabberd non-standard-uid /var/log/ejabberd ejabberd
E: ejabberd non-standard-uid /etc/ejabberd/ejabberd.cfg ejabberd
E: ejabberd non-standard-uid /etc/ejabberd ejabberd
E: ejabberd non-standard-uid /var/lib/ejabberd/spool ejabberd
E: ejabberd non-standard-uid /etc/ejabberd/inetrc ejabberd
E: ejabberd non-standard-uid /var/lib/ejabberd ejabberd
E: ejabberd non-standard-gid /var/log/ejabberd ejabberd
E: ejabberd non-standard-gid /etc/ejabberd/ejabberd.cfg ejabberd
E: ejabberd non-standard-gid /etc/ejabberd ejabberd
E: ejabberd non-standard-gid /var/lib/ejabberd/spool ejabberd
E: ejabberd non-standard-gid /etc/ejabberd/inetrc ejabberd
E: ejabberd non-standard-gid /var/lib/ejabberd ejabberd
Expected given that the daemon runs with its own uid/gid.

E: ejabberd non-standard-dir-perm /var/log/ejabberd 0750
E: ejabberd non-standard-dir-perm /etc/ejabberd 0750
E: ejabberd non-standard-dir-perm /var/lib/ejabberd/spool 0750
E: ejabberd non-standard-dir-perm /var/lib/ejabberd 0750
E: ejabberd non-readable /etc/ejabberd/ejabberd.cfg 0640
E: ejabberd non-readable /etc/ejabberd/inetrc 0640
Permissions limited for security reasons.

W: ejabberd non-conffile-in-etc /etc/logrotate.d/ejabberd
You should mark this as %config in your %files list.  This is the only rpmlint
issue that I see.

Nothing seems to own /usr/lib64/ejabberd-1.1.1.  This package should own it.

The documentation is about half of the total size of the package.  Would you
consider splitting the html, pdf and image files off into a separate -doc
subpackage?

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   ef6fae4a3f9c7f807f21e9cd3dae195b  ejabberd-1.1.1.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
X rpmlint has many ignorable complaints and one blocker.
* final provides and requires are sane:
   config(ejabberd) = 1.1.1-2.fc6
   ejabberd_zlib_drv.so()(64bit)
   expat_erl.so()(64bit)
   iconv_erl.so()(64bit)
   stringprep_drv.so()(64bit)
   tls_drv.so()(64bit)
   ejabberd = 1.1.1-2.fc6
  =
   /bin/bash
   /bin/sh
   /sbin/chkconfig
   /sbin/service
   config(ejabberd) = 1.1.1-2.fc6
   erlang
   fedora-usermgmt
   libcrypto.so.6()(64bit)
   libexpat.so.0()(64bit)
   libssl.so.6()(64bit)
   libz.so.1()(64bit)
* shared libraries are present, but internal to ejabberd.
* package is not relocatable.
X owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* scriptlets present and OK (user creation, service installation and shutdown)
* code, not content.
X documentation not is small.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.