[Bug 196434] Review Request: ren

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ren


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196434


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




------- Additional Comments From panemade at gmail.com  2006-06-23 07:38 EST -------
Not an official review as I'm not yet sponsored
Mock build fro i386 development is sucessfull

MUST Items:
     - MUST: rpmlint shows error 
       W: ren summary-not-capitalized rename multiple files
       Summary doesn't begin with a capital letter.
            Change Summary to Summary: Rename multiple files

      W: ren non-standard-group Utilities/File
      The group specified in your spec file is not valid. To find a valid group,
please refer to the  RPM documentation.
        No such groups exists. 
       
      W: ren invalid-license public domain
      The license you specified is invalid. The valid licenses are:

      -GPL                                    -LGPL
      -Artistic                               -BSD
      -MIT                                    -QPL
       -MPL                                    -IBM Public License
       -Apache License                         -PHP License
      -Public Domain                          -Modified CNRI Open Source License
      -zlib License                           -CVW License
      -Ricoh Source Code Public License       -Python license
      -Vovida Software License                -Sun Internet Standards Source License
       -Intel Open Source License              -Jabber Open Source License

      if the license is close to an existing one, you can use '<license> style'.
 
     Add License tag and any of above suitable open source license.

      W: ren no-url-tag
       Add URL: package hosting URL

      W: ren hardcoded-prefix-tag /usr
      The Prefix tag is hardcoded in your spec file. It should be removed, so as
to allow package relocation.
        Use macros instead hardcoding directories. check
http://www.fedoraproject.org/wiki/Extras/RPMMacros

       E: ren no-%clean-section
       The spec file doesn't contain a %clean section to remove the files
installed by the %install section.
        Add to SPEC file
       %clean
        rm -rf $RPM_BUILD_ROOT

       W: ren patch-not-applied Patch0: ren-1.0.Wall.patch
       A patch is included in your package but was not applied. Refer to the
patches documentation to see what's wrong.

       Move changelog at end.
         You need to read http://fedoraproject.org/wiki/Packaging/Guidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.