[Bug 193380] Review Request: hardinfo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hardinfo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193380





------- Additional Comments From cgoorah at yahoo.com.au  2006-06-23 14:30 EST -------
along with pciutils as BR

these have to be fixed:

chitlesh(i386)[0]$rpmlint -i hardinfo-0.4.1-1.i386.rpm
W: hardinfo no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

E: hardinfo script-without-shellbang /usr/share/hardinfo/benchmark.conf
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: hardinfo script-without-shellbang /usr/share/hardinfo/modules.conf
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: hardinfo script-without-shellbang /usr/share/hardinfo/uidefs.xml
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: hardinfo script-without-shellbang /usr/share/hardinfo/benchmark.data
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.


and Im wondering why have you not patch the hardinfo.desktop instead of creating
a new hardinfo.desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.