[Bug 195683] Review Request: smarteiffel - The GNU Eiffel Compiler and Libraries

bugzilla at redhat.com bugzilla at redhat.com
Sat Jun 24 10:54:24 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smarteiffel - The GNU Eiffel Compiler and Libraries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195683





------- Additional Comments From gemi at bluewin.ch  2006-06-24 06:46 EST -------
(In reply to comment #5)
> I agree about the debug package; there's no point in it.
> 
> I can't seem to reach upstream to download the source tarball at the moment.
I will use the current download url:
http://gforge.inria.fr/frs/download.php/586/SmartEiffel-2-2.tar.bz2

> W: smarteiffel conffile-without-noreplace-flag /etc/serc
> Not sure what's up here.  Is it expected that the user will need to edit this
> file?  If upgrading risks overwriting expected local configuration then
> noreplace is indeed the proper thing to do, but I suppose this may be an
> occasion where it's not warranted.
I don't think it makes much sense to change the settings in /etc/serc.

> E: smarteiffel zero-length /usr/share/SmartEiffel/short/tex3/hook832
> Generally zero-length files shouldn't be packaged, but I think in this case the
> file needs to be there.  (If I understand correctly, it's a formatting hook,
> where some text could be inserted at various points in some generated output.)
yes.

> W: smarteiffel non-standard-dir-in-usr libexec
> Seems acceptable to me, or at least in line with other accepted uses of libexec,
> although I wonder how this would work with multilib.
I always thought that /usr/libexec is the standard directory for executables
that are called as subprocesses and not directly by the user.
I really don't understand the warning, /usr/libexec seems pretty standard to
me...

> W: smarteiffel doc-file-dependency
> /usr/share/doc/smarteiffel-2.2/contrib/htmldoc/htmlshort /usr/bin/env
> (and several others)
> I don't think these should be executable.  (Wow, a program written in Ruby which
> handles running the SmartEiffel compiler under gdb.)
Hmm, if I chmod 0644 these files, I must also remove the shebang.
Maybe I should move the contrib directory to /usr/share/SmartEiffel.
There are also a few files to patch, paths etc...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list