[Bug 189884] Review Request: LASH Audio Session Handler

bugzilla at redhat.com bugzilla at redhat.com
Sun Jun 25 18:20:05 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LASH Audio Session Handler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189884


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-25 14:11 EST -------
Looks good now, Approved!

One last note though in the %post(un) scripts you should add "  || :" at the end
of the touch and gtk-update-icon-cache lines as documented here:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
This is so that if for whatever reason they fail that doesn't make the script
have a non zero return value and does the whole rpm (un)install transaction fail.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list