[Bug 196570] Review Request: mirage

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mirage


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196570


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




------- Additional Comments From panemade at gmail.com  2006-06-26 01:00 EST -------
Not an official review as I'm not yet sponsored
Mock build for development i386 is failed
  Add BuildRequires: desktop-file-utils
MUST Items:
     - MUST: rpmlint shows no error 
     - MUST: dist tag is present
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package mirage, in the
format mirage.spec
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license GPL.
    - MUST: The License field in the package mirage.spec file matches the
actual license file COPYING in tarball.
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
      - MUST: This package  have a %clean section, which contains rm -rf
 %{buildroot}.
      - MUST: This package used macros.
      - MUST: Document files are included like README.
      - MUST: Library files that end in .so (without suffix) are NOT in a -devel
package.
      - MUST: This package contains shared library files located in the dynamic
linker's default paths, and But this package did NOT calling ldconfig in %post
and %postun. 
      * Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is NOT correct

 What you Need to Do:-
      * As your package uses .so files. You can add subpackage -devel.
      * BuildRequires needed desktop-file-utils to be added.
      * add %post %postun sections with call to ldconfig as
       %post -p /sbin/ldconfig
       %postun -p /sbin/ldconfig
      * update-desktop-database dependancy missing  for %post (package
desktop-file-utils) as well as for %postun (package desktop-file-utils)








-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.