[Bug 186817] Review Request: kshutdown

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kshutdown


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186817





------- Additional Comments From cgoorah at yahoo.com.au  2006-06-26 04:59 EST -------
This is not an official review:

- MUST: rpmlint gives warnings, which should be corrected.
W: kshutdown hidden-file-or-dir
/usr/share/apps/kshutdown/extras/multimedia/.directory
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

W: kshutdown dangling-symlink /usr/share/doc/HTML/de/kshutdown/common
/usr/share/doc/HTML/de/common
The symbolic link points nowhere.

W: kshutdown symlink-should-be-relative /usr/share/doc/HTML/de/kshutdown/common
/usr/share/doc/HTML/de/common
W: kshutdown hidden-file-or-dir /usr/share/apps/kshutdown/extras/shutdown/.directory
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

W: kshutdown hidden-file-or-dir /usr/share/apps/kshutdown/extras/system/.directory
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

W: kshutdown dangling-symlink /usr/share/doc/HTML/en/kshutdown/common
/usr/share/doc/HTML/en/common
The symbolic link points nowhere.

W: kshutdown symlink-should-be-relative /usr/share/doc/HTML/en/kshutdown/common
/usr/share/doc/HTML/en/common


- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the format %{name}.spec
- MUST: The package must meet the Packaging Guidelines.
- MUST: The package is under the GPL license.
- MUST: The License field in the package spec file matches the actual license.
- MUST: The source package does not include the text of the license(s) in its
own file, then the file, containing the text of the license(s) for the package
does not need to be included in %doc.
- MUST: The spec file is written in American English.
- MUST: The spec file for the package is legible.
- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task.
- MUST: The package must successfully compile and build into binary rpms at
least on i386.

Though there are
+ make -j3
Makefile:849: warning: overriding commands for target `clean-bcheck'
Makefile:812: warning: ignoring old commands for target `clean-bcheck'
Makefile:854: warning: overriding commands for target `bcheck-am'
Makefile:817: warning: ignoring old commands for target `bcheck-am'
make  all-recursive
make[1]: Entering directory `/home/chitlesh/rpmbuild/BUILD/kshutdown-0.8.2'
Makefile:849: warning: overriding commands for target `clean-bcheck'
Makefile:812: warning: ignoring old commands for target `clean-bcheck'
Makefile:854: warning: overriding commands for target `bcheck-am'
Makefile:817: warning: ignoring old commands for target `bcheck-am'            
                                             

I have also encountered the above, I don't know whether this should be ignored
or not.

- MUST: All build dependencies are listed in BuildRequires
- MUST: The spec file handles locales properly. 
- MUST: A package owns all directories that it creates.
- MUST: A package does not contain any duplicate files in the %files listing.
- MUST: Permissions on files has been set properly.
- MUST: Each package haq a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).

- MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.

You should use macros on the %files section.
and you can even use %{_docdir} instead of %{_datadir}/doc/

- MUST: The package contains code, or permissable content.

But the "sounds" folder contains *.ogg fils which are copyrighted (C) Caryn
"Hellchick" Law

- MUST: No Large documentation files, hence no need for a -doc subpackage.

- MUST: The package does not include %doc

for this package, you can use 
%doc AUTHORS COPYING NEWS README TODO VERSION


- MUST: The Package containing GUI application includes a %{name}.desktop file.

SHOULD Items:

- SHOULD: If the source package does not include license text(s) as a separate
file from upstream

 you SHOULD query upstream to include it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.