[Bug 185845] Review Request: rpld - RPL/RIPL remote boot daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rpld - RPL/RIPL remote boot daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185845


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list at redhat.com             |review at redhat.com

tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2006-06-26 21:39 EST -------
I saw that this had been sitting for a bit and thought I'd take a look, but
there are major problems getting this build.

First off, you need BuildRequires: byacc, flex

That gets things to build to the point where it tries to install rpld as a
different user:

install -c -o root -g kmem -m 555 rpld /var/tmp/rpld-1.8-1-root-mockbuild/usr/sbin

That is never allowable; it should put the file into place and rely on the
%files section to set the ownership.  This should be pretty easy to patch out of
the Makefile.

Finally, the compiler isn't called with the proper flags; you need to pass in
$RPM_OPT_FLAGS somehow.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.