[Bug 193380] Review Request: hardinfo
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jun 27 08:33:46 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: hardinfo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193380
------- Additional Comments From cgoorah at yahoo.com.au 2006-06-27 04:25 EST -------
(In reply to comment #13)
Damien, that's why I had included this in my spec file send to you
> Builds fine in mock and works as expected.
> * rpmlint output:
> W: hardinfo no-documentation
> At least the license file should be included.
%doc LICENSE
> * there is no need for /sbin/ldconfig in the scripts
%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%{_datadir}/applications/fedora-%{name}.desktop
> * there are now two desktop files in %{_datadir}/applications
> as has already been said, just modify the included
> desktop file
> *
desktop-file-install --vendor fedora \
--dir ${RPM_BUILD_ROOT}%{_datadir}/applications \
--add-category X-Fedora \
--add-category System \
--delete-original \
$RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list