[Bug 196824] Review Request: php-pear-Mail_Mime

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 28 01:12:06 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Mail_Mime
Alias: php-pear-Mail_Mime

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196824





------- Additional Comments From holbrookbw at users.sourceforge.net  2006-06-27 21:03 EST -------
I have added the version dependencies for (post) and (postun), as well as
modified the defattr.  I have no problem changing the package name or owning the
Mail/ directory, but have some questions first:

I named this package using FE's guidelines for perl/cpan packages
'perl-CPANDIST' where CPANDIST is the name of the module in CPAN.  I adopted
this for pear to read 'php-pear-PEARDIST'.  Since Mail_Mime is not a sub-package
of Mail, using a '-' to delimit Mail and Mime seems misleading to me.  Mail_Mime
does not depend on Mail, but Mail-Mime looks like it might.  I'd love to change
it if you still feel the 'no underscore' rule precludes all other naming
conventions, just putting in my 0.02 :)

Also, and along the same lines, owning the Mail/ directory seems like a bad idea
to me.  Pear contains many Mail_xxx packages
(http://pear.php.net/search.php?q=mail&in=packages&x=0&y=0), none of which
depend on the Mail package, but (I assume) all of which place files in the Mail/
directory.  It's hard to say which of these packages should own Mail/, but we
also can't rely on Mail to own it, as one could easily have Mail_Mime installed
without installing Mail.  (For FE, we could force the Mail package to own Mail/
and then force Mail_xxx packages to require Mail even though they don't...)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list