[Bug 193531] Review Request: kicad - Electronic schematic diagrams and printed circuit board artwork

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kicad - Electronic schematic diagrams and printed circuit board artwork


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193531





------- Additional Comments From cgoorah at yahoo.com.au  2006-06-28 07:05 EST -------
This is not an official review:

- MUST: rpmlint gives warnings, which should be corrected.

chitlesh(i386)[0]$rpmlint -i kicad-2006-04-24-0-4.i386.rpm
W: kicad-2006-04-24 incoherent-version-in-changelog 2006-04-24-0-4 0-4
Your last entry in %changelog contains a version that is not coherent with
the current version of your package.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/contents.hhc
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/pcbnew/pcbnew.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 file-not-utf8 /usr/share/doc/kicad/en/pcbnew/doc_pcbnew.zip
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/author.txt
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/kicad/kicad.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/cvpcb/cvpcb-en.pdf
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

E: kicad-2006-04-24 script-without-shellbang
/usr/share/doc/kicad-2006-04-24-0/gpl.txt
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: kicad-2006-04-24 wrong-script-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/gpl.txt
This script has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It will prevent its execution.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/pcbnew/pcbnew.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

E: kicad-2006-04-24 script-without-shellbang
/usr/share/doc/kicad-2006-04-24-0/readme.txt
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: kicad-2006-04-24 wrong-script-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/readme.txt
This script has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It will prevent its execution.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/contents.hhc
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/contrib.txt
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/cvpcb/cvpcb.pdf
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/pcbnew/pcbnew.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/eeschema/eeschema.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/cvpcb/cvpcb-pt.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/contents.hhc
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/cvpcb/cvpcb-fr.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/eeschema/eeschema-pt.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/eeschema/eeschema.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

E: kicad-2006-04-24 script-without-shellbang
/usr/share/doc/kicad-2006-04-24-0/version.txt
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/pcbnew/pcbnew-es.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/kicad/kicad-es.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/contents.hhc
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/kicad.hhp
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/doc_conv_orcad_to_kicad.txt
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

E: kicad-2006-04-24 script-without-shellbang
/usr/share/doc/kicad-2006-04-24-0/licendoc.txt
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: kicad-2006-04-24 wrong-script-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/licendoc.txt
This script has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It will prevent its execution.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/file_formats/file_formats.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/kicad/kicad-pt.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/eeschema/Eeschema_Chapter1_ES.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/kicad/kicad.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/kicad.hhp
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/doc_conv_orcad_to_kicad_spanish.txt
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/gerbview/gerbview.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/eeschema/eeschema.pdf
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/eeschema/eeschema-es.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/cvpcb/cvpcb-es.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/eeschema/eeschema.pdf
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/kicad/kicad.pdf
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/gerbview/gerbview.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/gerbview/gerbview.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/cvpcb/cvpcb-en.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/gerbview/gerbview.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/en/file_formats/file_formats.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/pt/file_formats/file_formats.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/fr/kicad.hhp
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

E: kicad-2006-04-24 script-without-shellbang
/usr/share/doc/kicad-2006-04-24-0/copyright.txt
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: kicad-2006-04-24 wrong-script-end-of-line-encoding
/usr/share/doc/kicad-2006-04-24-0/copyright.txt
This script has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It will prevent its execution.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/file_formats/file_formats-es.html
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

W: kicad-2006-04-24 wrong-file-end-of-line-encoding
/usr/share/doc/kicad/es/kicad.hhp
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.


- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the format %{name}.spec
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is under the GPL license.
- MUST: The License field in the package spec file matches the actual license.
- MUST: The source package includes the text of the license(s) in its
own file
- MUST: The spec file is written in American English.
- MUST: The spec file for the package is legible.
- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task.

The following URL is invalid.
Source1:	http://linuxelectronique.free.fr/download/kicad-src-extras.tar.bz2

- MUST: The package must successfully compile and build into binary rpms at
least on i386.
- MUST: All build dependencies are listed in BuildRequires
- MUST: The spec file handles locales properly. 
- MUST: A package owns all directories that it creates.
- MUST: A package does not contain any duplicate files in the %files listing.
- MUST: Permissions on files has been set properly.
- MUST: Each package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
- MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.

I will advise you to opt for %{name} instead of "kicad"

- MUST: The package contains code, or permissable content.
- MUST: No Large documentation files, hence no need for a -doc subpackage.
- MUST: The package includes %doc
- MUST: The Package containing GUI application includes a %{name}.desktop file.

- SHOULD: the source package includes license text(s) as a separate file from
upstream
- SHOULD: The description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.