[Bug 196625] Review Request: perl-SVN-Simple - a simple interface to subversion's editor interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Simple - a simple interface to  subversion's editor interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196625


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-28 13:51 EST -------
This fails to build in mock; you are missing a BuildRequires: perl(SVN::Core)
(which ends up being provided by subversion-perl).  I'm going to assume for the
purposes of this review that it's been added.

Since that's the only issue, I'll go ahead and approve and you can fix it when
you check in.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream. 
* source files match upstream:
   6a5609e038421564051019649dd05fd0  SVN-Simple-0.27.tar.gz
* latest version is being packaged.
X BuildRequires are proper (needs perl(SVN::Core).)
O package builds in mock (development, x86_64) (once the needed BR: is added.)
* rpmlint is silent.
* final provides and requires are sane:
   perl(SVN::Simple::Edit) = 0.27
   perl(SVN::Simple::Editor)
   perl-SVN-Simple = 0.27-2.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(File::Spec::Unix)
   perl(SVN::Core)
   perl(SVN::Delta)
   perl(strict)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=8,  0 wallclock secs ( 0.12 cusr +  0.03 csys =  0.15 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.