[Bug 192311] Review Request: cobbler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cobbler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311





------- Additional Comments From mdehaan at redhat.com  2006-06-28 17:50 EST -------
All items are now fixed except for the part about the 'dist tag', which I did
not understand, and the relocatable part, which AFAIK, I have not marked the
package relocatable.  Pointers on these two items would be greatly appreciated.

I've updated the src rpms, noarch rpms, and spec files accordingly.

===

Wrap at 80 characters.
* Fixed

E: cobbler no-changelogname-tag
You need a %changelog
* Fixed

E: cobbler non-executable-script
/usr/lib/python2.4/site-packages/cobbler/cobbler.py 0644
Begins with #!/usr/bin/python, ignorable.
* Fixed anyway

Package is marked as relocatable, please check.
  (wiki: Packaging/Guidelines#RelocatablePackages)
* I don't see "relocatable" in the spec file.  So I'm not sure how the package
is marked as such.

Spec file: tag Vendor is forbidden
  (wiki: Packaging/Guidelines#tags)
* Fixed

No downloadable source. Please give the full URL in the Source tag.
* Fixed.  The source is also in the bugzilla entry at the top of this page.

The BuildRoot must be cleaned at the beginning of %install
* Fixed.

Also You need to use dist tag instead of coding release
* Can you elaborate on what needs to be done here?

Source tag is not a URL
* Fixed

Add Changelog
* Fixed

===




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.