[Bug 196620] Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jun 28 22:10:39 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196620
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink at leemhuis.info |tibbs at math.uh.edu
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-06-28 18:02 EST -------
It's worse than superfluous. You get this in the dependency list:
perl(Algorithm::Diff)
perl(Algorithm::Diff) >= 1.15
I have no problem with you specifying a specific version, although as far as I
can tell the earliest version that was ever in Extras was 1.19 so you shouldn't
need to worry. If you really want to, however, you _must_ filter the
unversioned dependency generated by RPM. Let me know if you need help doing this.
The package does build in mock; rpmlint has this to day:
W: perl-Algorithm-Annotate incoherent-version-in-changelog 0.10-2 0.10-3.fc6
You neglected to add a changelog entry for the last version bump.
Also, your %doc tag has no files. I understand that there are none to ship, so
you should just remove it.
So I see three blockers.
Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* source files match upstream:
453395489640e28fc772944ef08d396b Algorithm-Annotate-0.10.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
X final requires list has a duplicate entry:
perl(Algorithm::Annotate) = 0.10
perl-Algorithm-Annotate = 0.10-3.fc6
=
perl(:MODULE_COMPAT_5.8.8)
X perl(Algorithm::Diff)
X perl(Algorithm::Diff) >= 1.15
perl(strict)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
All tests successful.
Files=1, Tests=3, 0 wallclock secs ( 0.02 cusr + 0.02 csys = 0.04 CPU)
* no scriptlets present.
* code, not content.
X no documentation, but empty %doc tag.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list