[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627





------- Additional Comments From tibbs at math.uh.edu  2006-06-28 19:35 EST -------
OK, indeed the test failures are gone under FC5.  Still, this is going to cause
significant trouble going forward.

I will attach a full build log with TEST_VERBOSE=1 and hopefully this will help
you.  It almost looks like the error isn't even in this module.  There are
several of these:

TypeError in method 'svn_ra_reporter2_invoke_set_path', argument 6 of type 'char
const *'

That method string doesn't match anything in the source; it looks like some
issue with some generated bindings.  Perhaps it's a subversion-perl issue?  I
suggest you work with upstream and perhaps ping fedora-perl-list.

I will review this package based on an FC5 build.  The only issue that turns up
is your manual versioned dependency for perl(SVN::Core) which conflicts with one
determined by RPM.  You'll either need to drop the manual dependency or filter
out the one RPM finds.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   acc9a1b4d3bf3b633892b5fe0c183266  SVN-Mirror-0.68.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (FC5, x86_64). (fails to build on development)
* rpmlint is silent.
X final provides and requires are sane:
   perl(SVN::Mirror) = 0.68
   perl(SVN::Mirror::Git) = 0.62
   perl(SVN::Mirror::Ra) = 0.68
   perl(SVN::Mirror::Ra::MirrorEditor)
   perl(SVN::Mirror::VCP) = 0.50
   perl-SVN-Mirror = 0.68-6.fc5
  =
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.8.8)
   perl(Class::Accessor)
   perl(Date::Format)
   perl(File::Path)
   perl(File::Spec)
   perl(File::Spec::Functions)
   perl(File::Spec::Unix)
   perl(File::chdir)
   perl(Getopt::Long)
   perl(SVN::Client)
   perl(SVN::Core)
X  perl(SVN::Core) >= 1.0.7
   perl(SVN::Delta)
   perl(SVN::Fs)
   perl(SVN::Mirror)
   perl(SVN::Mirror::Ra)
   perl(SVN::Ra)
   perl(SVN::Repos)
   perl(SVN::Simple::Edit)
   perl(Sys::Hostname)
   perl(Term::ReadKey)
   perl(Time::HiRes)
   perl(URI)
   perl(URI::Escape)
   perl(base)
   perl(constant)
   perl(strict)
   perl(warnings)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass (on FC5; some tests fail on development)
   All tests successful, 2 tests skipped.
   Files=9, Tests=100, 59 wallclock secs ( 9.33 cusr +  8.14 csys = 17.47 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.