[Bug 196865] Review Request: audacious - A GTK2 based media player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious - A GTK2 based media player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196865





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-29 09:23 EST -------
MUST:
=====
* rpmlint output is:
W: audacious strange-permission audacious-fedora-1.1.0-dr2.tar.gz 0600
W: audacious strange-permission audacious.spec 0600
W: audacious strange-permission audacious-1.1.0-xmms-skins.patch 0600
W: audacious strange-permission audacious-1.1.0-default-skin.patch 0600
W: audacious prereq-use desktop-file-utils >= 0.9
W: audacious incoherent-version-in-changelog 1.1.0-dr2 1.1.0-0.0.dr2
E: audacious binary-or-shlib-defines-rpath /usr/bin/audacious ['/usr/lib']
W: audacious symlink-should-be-relative /usr/lib/libaudacious.so.2
/usr/lib/libaudacious.so.2.0.0
W: audacious-devel no-documentation
W: audacious-devel symlink-should-be-relative /usr/lib/libaudacious.so
/usr/lib/libaudacious.so.2
These all must be fixed except for the no-doc warning for -devel
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream, expect for stripped parts
* Compiles and builds on devel-i386
* BR: some are missing see must fix
* Locales handled properly
* ldconfig properly called for shared libs
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* -devel package as needed
* no .la files
* .desktop file as required and properly installed


MUST fix:
=========
* rpmlint output, let me know if you need help with fixing the rpath usage,
  for some reason many new packages have this and I'm getting quite skilled
  in fixing these.
* Remove the unnescesarry commented libXxxxxx Requires
* Add missing BR: lirc-devel, so that lirc support gets compiled in.
* Add missing BR: libmodplug-devel, so that modplug support gets compiled in.
* Add missing BR: bison, configure checks for bison and bison is no longer
  in our default buidroot.
* Remove --disable-oss from %configure's flags. Some people may have cards
  which only work with oss drivers and it does 0 harm (no extra deps, dynamicly
  loaded, so cannot cause any bugs when not used).
* Under %files I see %{_datadir}/pixmaps/audacious.png, that is not according to
  the freedesktop.org icon standard, it should go under:
  %{_datadir}/icons/hicolor/32x32/apps
  Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/
  to see the available valid sizes, if the icon doesn't match any pick the 
  closest.
* Once the icon is in the proper case you must add %post(un) script to update 
  the icon-cache see:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
* remove the spurious: # rm -f $RPM_BUILD_ROOT%{_infodir}/dir

Should fix:
===========
* I think it would be better to only strip the dirs containing the offending
  code and to not change Makefile.in and configure in the tarball, keeping
  things as much in sync with upstream impossible. Put the nescesarry
  Makefile.in and configure changes in a patch instead.
* Obsolete: bmp
* Most packages I've seen do this:
desktop-file-install --vendor fedora \
    --dir $RPM_BUILD_ROOT%{_datadir}/applications   \
    --add-category X-Fedora  \
    --add-category Application  \
    --remove-mime-type audio/mp3 \
    --remove-mime-type audio/x-mp3 \
    --remove-mime-type audio/mpeg \
    --remove-mime-type audio/x-mpeg \
    audacious/audacious.desktop
rm -f $RPM_BUILD_ROOT%{_datadir}/applications/audacious.desktop

Like this:
desktop-file-install --vendor fedora \
    --dir $RPM_BUILD_ROOT%{_datadir}/applications   \
    --add-category X-Fedora  \
    --add-category Application  \
    --remove-mime-type audio/mp3 \
    --remove-mime-type audio/x-mp3 \
    --remove-mime-type audio/mpeg \
    --remove-mime-type audio/x-mpeg \
    --delete-original \
    $RPM_BUILD_ROOT%{_datadir}/applications/audacious.desktop

Hint the difference is in the last 2 lines :) The second way is advised on the
scriptlets page I believe.


Nice to Have:
=============
* Add BR: jack-audio-connection-kit-devel, libsamplerate-devel to enable
  the jack output plugin.
* Put the jack output plugin into a subpackage so that jack and samplerate
  don't get sucked in as Requires for users who don't need jack
* Put the arts output plugin into a subpackage so that qt and arts don't
  get sucked in as dependencies for non kde users.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.