[Bug 188435] Review Request: glibrary-1.0.1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glibrary-1.0.1


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188435


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2006-05-01 12:07 EST -------
Much better! The one point (not a blocker) is that you can use:
%{_datadir}/%{name}/

instead of 

%{_datadir}/%{name}/*

Gives you the same end result. I try to avoid * wherever possible.

Good:

- rpmlint checks return:

W: glibrary incoherent-version-in-changelog 1.0.1-2 1.0.1-1
E: glibrary script-without-shellbang /usr/share/doc/glibrary-1.0.1/README
E: glibrary script-without-shellbang /usr/share/doc/glibrary-1.0.1/AUTHORS
E: glibrary script-without-shellbang /usr/share/doc/glibrary-1.0.1/COPYING
E: glibrary script-without-shellbang /usr/share/doc/glibrary-1.0.1/ChangeLog

Make sure you bump your release number when you make a change. :)
Also, you should chmod -x those doc files, so that rpmlint doesn't think that
they are scripts.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales handled properly
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file ok (might consider adding an icon)

All in all, this is much better. Just some minor changes to make before you
build, but I'm convinced that you have a better grasp on things.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.