[Bug 190000] Review Request: partimage

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: partimage


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190000





------- Additional Comments From dcantrel at redhat.com  2006-05-04 13:53 EST -------
(In reply to comment #6)
> Bad:
> - Buildroot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Corrected.

> - Server requires should probably be %{name} = %{version}-%{release}

Had that originally.  Changed back.

> - Doesn't build on x86_64:

Does now.

> rpmlint isn't very happy w/ the 32bit package either.

Well, it should quit being so pedantic.
 
> W: partimage conffile-without-noreplace-flag /etc/pam.d/partimage
> W: partimage conffile-without-noreplace-flag /etc/security/console.apps/partimage

Added noreplace.

> E: partimage use-old-pam-stack /etc/pam.d/partimage
> E: partimage use-old-pam-stack /etc/pam.d/partimage

Corrected.

> W: partimage-server conffile-without-noreplace-flag /etc/logrotate.d/partimaged
> W: partimage-server conffile-without-noreplace-flag /etc/pam.d/partimaged
> W: partimage-server conffile-without-noreplace-flag /etc/rc.d/init.d/partimaged

Added noreplace.

> E: partimage-server non-readable /etc/partimaged/partimagedusers 0600

Corrected.

> E: partimage-server executable-marked-as-config-file /etc/rc.d/init.d/partimaged

Not marking it as a config file.

> E: partimage-server incoherent-logrotate-file /etc/logrotate.d/partimaged

Corrected.

> W: partimage-server file-not-in-%lang /usr/share/man/en/man5/partimagedusers.5.gz
> W: partimage-server file-not-in-%lang /usr/share/man/en/man8/partimaged.8.gz

Corrected.

> W: partimage-server incoherent-subsys /etc/rc.d/init.d/partimaged $prog
> W: partimage-server incoherent-init-script-name partimaged

Corrected.

> E: partimage-server use-old-pam-stack /etc/pam.d/partimaged
> E: partimage-server use-old-pam-stack /etc/pam.d/partimaged
> E: partimage-server use-old-pam-stack /etc/pam.d/partimaged

Corrected.

> Indifferent: 
> - %description is a bit long winded...

Removed last two paragraphs.  People don't read anyway.

> - chmod of pam.d/partimaged followed by install -m seems redundant.

Look more closely.  There are two pam.d files:  partimage and partimaged.  One I
have to change the SYSCONFDIR in during installation, so I use sed and chmod. 
The other I can install directly, so I use install.

> NEEDSWORK

Grade me again, TA.

Package and spec file can be found at http://people.redhat.com/dcantrel/core/

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.