[Bug 188482] Review Request: scipy-0.4.8

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scipy-0.4.8


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188482





------- Additional Comments From ed at eh3.com  2006-05-06 13:15 EST -------
Hi Neal, heres a few more comments (not a thorough review):

good:
 + license is OK: its BSD-w/o-advertise-clause
 + source matches upstream

needswork:
 - missing license file (please add "%doc LICENSE.txt")
 - missing "BuildRequires: numpy"
 - please use "%setup -q"

Also, *please* build your package locally in mock.  The commands are:

 1) yum install mock
 2) add yourself to the mock group (vi /etc/group)
 3) log out/in for group addition to take full effect
 4) run "mock -r fedora-5-i386-core scipy-0.4.8-2.src.rpm"

and it will help you identify problems.  Its a very good idea since 
mock is what the buildsystem itself uses.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.