[Bug 189727] Review Request: Scribes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Scribes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189727





------- Additional Comments From bdpepple at ameritech.net  2006-05-06 14:01 EST -------
MD5Sums:
5031eaa0ef8817ea32d390fc4d26ceda  scribes-0.2.4.3.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Builds fine in mock.

Minor:
* Non-blocker rpmlint errors, that are being addressed upstream: 
  E: scribes zero-length /usr/share/gnome/help/scribes/C/figures/scribes_status.png
E: scribes zero-length /usr/share/gnome/help/scribes/C/figures/scribes_editing.png

Bad:
* In your schemas scriptlets you can drop the 'killall -HUP gconfd-2 || :',
since it's no longer needed in FC5 and above.
* Instead of Requires for yelp, you should be using scrollkeeper, and it's
associated scriptlets.
http://fedoraproject.org/wiki/ScriptletSnippets#head-3c9f517f0cd4aaabb369a8805226d85dc2f02793

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.