[Bug 190583] Review Request: perl-Test-Differences - Test strings and data structures and show differences if not ok

bugzilla at redhat.com bugzilla at redhat.com
Sun May 7 01:53:14 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Differences - Test strings and data structures and show differences if not ok


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190583


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-05-06 21:52 EST -------
Things build OK and the test suite says that it passes, but test 01text_vs_data
is really noisy and looks like it should be failing.  I'm guessing it's just
stray output from the test.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently, and
follows the Perl specfile template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   e4fa76bb11b0d1db2d4213390413f5af  Test-Differences-0.47.tar.gz
   e4fa76bb11b0d1db2d4213390413f5af  Test-Differences-0.47.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=7, Tests=23,  1 wallclock secs ( 0.22 cusr +  0.08 csys =  0.30 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list