[Bug 191005] Review Request: glob2 - Realtime Strategy game

Mon May 8 02:20:05 UTC 2006

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glob2 - Realtime Strategy game

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191005

bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |177841
              nThis|                            |

------- Additional Comments From bdpepple at ameritech.net  2006-05-07 22:20 EST -------
Couple of quick items: 

1. In the files section, you need to use macros instead of hard-coding the path.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-255d52ff18f82fa184a32946b82ed81e4fd8885a
2. The desktop file is not handled correctly.
3. The documentation (AUTHORS file) is not handled correctly.
4. Instead of listing every file, you should use a less verbose method (ie.
%{_datadir}/pixmaps/*.png).
5. A lot of your Requires aren't necessary, since the BuildRequires sonames will
cause these to be pulled in automatically.

Most of the solutions to these issues can be found on the wiki.
http://fedoraproject.org/wiki/Packaging/Guidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.