[Bug 190705] Review Request: perl-Test-Base

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705


jpo at di.uminho.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jpo at di.uminho.pt




------- Additional Comments From jpo at di.uminho.pt  2006-05-07 23:12 EST -------
I've some reservations about the approval of this module.  It appears to have
several optional/missing Requirements and BR.

  BR: Text::Diff, YAML
  Req: Text::Diff, LWP::Simple, YAML

I think we should at least 
   BuildRequires: perl(Text::Diff)
and
   Requires: perl(Text::Diff), perl(LWP::Simple)

Note: IIRC the new version of YAML requires Test::Base  => may cause circular
dependencies problems.
Note2: It's 4:00am. I will give another look at this module in a few hours.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.