[Bug 191036] Review Request: libmp4v2 a library for handling the mp4 container format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmp4v2 a library for handling the mp4 container format


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191036





------- Additional Comments From mpeters at mac.com  2006-05-08 07:47 EST -------
I can't sponsor, but some notes:

---
%files
%doc COPYING
%defattr(-,root,root,-)
%{_bindir}/*
%{_libdir}/*.so.*
---

Normally - %doc goes below %defattr line

---
%files devel
%doc README TODO INTERNALS API_CHANGES
%doc %{_mandir}/man?/*
%{_includedir}/*.h
%{_libdir}/*.a
%{_libdir}/*.so
---

You nead a defattr line here.
Don't use %doc with %{_mandir} - it isn't necessary.
Don't package the static library (unless you know you need it)

----
I see shared libraries - but don't see ldconfig run in %post or %postun.

Changelog version refers to lvn - it should just be

1.4.1-1

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.