[Bug 188369] Review Request: ctapi-cyberjack

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ctapi-cyberjack


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188369





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-05-08 08:25 EST -------
MUST:
=====
* rpmlint output is:
W: ctapi-cyberjack one-line-command-in-%postun /sbin/ldconfig
This one needs fixing, replace:
%postun
/sbin/ldconfig
with:
%postun -p /sbin/ldconfig
The same goes for %post, but rpmlint doesn't detect that one?
W: ctapi-cyberjack-devel no-documentation
W: ctapi-cyberjack-pcsc no-documentation
These may be ignored
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64 & devel-i386
* BR: ok
* No locales
* Shared libraries, ldconfig is run
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* -devel package for the .h file(s)
* no gui -> no .desktop file required


MUST fix:
=========
* Replace:
   %postun
   /sbin/ldconfig
  with:
   %postun -p /sbin/ldconfig
  The same goes for %post.
* The pcsc ifd gets installed as  /libcyberjack_ifd.so which is ofcourse not
  correct.

Should fix:
===========
* You could replace sed -e '....' aap > aap.tmp; mv aap.tmp aap with:
  sed -i '....' aap
* %package pcsc is missing the following Requires:
   Requires(post): /usr/sbin/update-reader.conf
   Requires(postun): /usr/sbin/update-reader.conf
 Although this does get provides by the Requires: pcsc-lite, why this
 Requires? Wouldn't the above 2 be better?

Concider yourself sponsored, feel free to create an account in the account
system and sign the CLA I'll sponsor you once thats done.

I'm awaiting the next and hopefully final revision of this package.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.