[Bug 187430] Review Request: elektra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elektra


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187430





------- Additional Comments From mpeters at mac.com  2006-05-08 09:37 EST -------
Suggestions:

in /etc/profile.d/elektraenv.sh :

FILE="/tmp/elektraenv${RANDOM}${RANDOM}"

should perhaps be

FILE="`mktemp -t elektraenv.XXXXXX`"

-=-

Most (all?) core packages that provide a .sh profile.d file also provide a .csh
equivalent. It might be a good idea to port the script to csh.

-=-

As mentioned above - the following are packaging mistakes.

in %files:
%doc %{_docdir}/%{name}

in %files devel:
%doc %{_docdir}/%{name}-devel

The Makefile should not install them into /usr/share (or they should be removed
after make install) and instead they should be packaged with %doc in this way:

%install
*stuff currently in %install, followed by*
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/%{name}
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-devel
rm -f scripts/Makefile*
rm -rf examples/Makefile* examples/*.xml
mv doc/elektra-api/html ./api-html

in %files:
%doc scripts

in %files devel:
%doc examples api-html

That should result in those docs being properly packaged.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.