[Bug 191005] Review Request: glob2 - Realtime Strategy game

bugzilla at redhat.com bugzilla at redhat.com
Mon May 8 18:57:49 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glob2 - Realtime Strategy game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191005





------- Additional Comments From bdpepple at ameritech.net  2006-05-08 14:57 EST -------
Couple of items:

1. Package fails to build in Mock.  Your missing a BuildRequirement.  For
information on Mock refer to: http://fedoraproject.org/wiki/Extras/MockTricks
2. Not a blocker, but in the files section, use %{_datadir}/%{name}/, instead of
individually listing the children directories.
3. The docs can be listed on one line with a space between each document.  If
this doesn't make sense, look at this for an example of what I'm talking about:
http://cvs.fedora.redhat.com/viewcvs/devel/gnomebaker/gnomebaker.spec?root=extras&view=markup
4. Instead of one long line in your desktop-file-install call how about some
line breaks to make it easier to read.  Refer to the above spec, if you've got
questions.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list