[Bug 190175] Review Request: p0rn-comfort - Support programs for browsing image-gallery sites

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: p0rn-comfort - Support programs for browsing image-gallery sites


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190175





------- Additional Comments From tibbs at math.uh.edu  2006-05-08 21:30 EST -------
I know I promised on IRC to look into this some time ago; sorry it took me so
long to get to it.

Some might be put off by the name, but this is really just a simple web proxy
with some interesting features relating to automated fetching of linked images.

I'm inclined to approve, but first I'd like to ask if you've given any thought
to moving those executables which aren't intended to be run to the user
(p0rn-db*, perhaps not p0rn-dbdump) to a directory under /usr/lib.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible; license text is included in the package.
* source files match upstream:
   08be31c527f7577765c4721d1bdf02f7  p0rn-comfort-0.0.4.tar.gz
   08be31c527f7577765c4721d1bdf02f7  p0rn-comfort-0.0.4.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
O %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.