[Bug 189151] Review Request: xsp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xsp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From bdpepple at ameritech.net  2006-05-09 12:27 EST -------
Rest of review in comment #5.  Looks pretty good, except for the following issues:  

1. The URL should be 'http://www.mono-project.com/ASP.NET#XSP', and the Source
URL should be 'http://www.go-mono.com/sources/xsp/%{name}-%{version}.tar.gz'.
2. Use '%{_libdir}/%{name}/' instead of '%{_libdir}/xsp/1.0/*'.  In general, you
want to refrain from using a wildcard to pull in children directories, since
this can cause directory ownership issues.
3. The License appears to be BSD, not GPL.
4. The COPYING file should be added to the documentation.

Once these items are corrected, go ahead and import it into FE CVS.

+1 APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.