[Bug 189755] Review Request: pypoker-eval - Python Interface to poker-eval

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pypoker-eval - Python Interface to poker-eval


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189755





------- Additional Comments From tibbs at math.uh.edu  2006-05-09 13:53 EST -------
I'm not a Python expert, but I promised on IRC that I'd take a look, so....

The only issue I see is the unversioned .so file.  If you have versioned
libraries, the unversioned link needs to live in the -devel package.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible; license text is included in the package.
* source files match upstream:
   2ec8a95a5d0880e99ad4695ec113b799  pypoker-eval-131.0.tar.gz
   2ec8a95a5d0880e99ad4695ec113b799  pypoker-eval-131.0.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
X shared libraries are present.  They are internal to python so there's no need
to run ldconfig, but the inversioned .so file needs to be moved to the devel
package.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* .pyo files are ghosted properly.
* file permissions are appropriate.
* %clean is present.
O %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* pkgconfig file is in the -devel package.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.