[Bug 191070] Review Request: mcstrans

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mcstrans


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191070





------- Additional Comments From jkeating at redhat.com  2006-05-09 17:58 EST -------
Bad:
- buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Source url is 404: http://fedora.redhat.com/projects/mcstrans-0.1.1.tgz
- Build fails on both arches, probably a missing BuildRequires:

mcstransd.c:16:29: error: selinux/setrans.h: No such file or directory



Should be fixed:
- Mix of variables like $RPM_BUILD_ROOT and %{optflags}.  One method should be
consistant throughout

NEEDSWORK

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.