[Bug 191239] Review Request: qjackctl - Qt based JACK control application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qjackctl - Qt based JACK control application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239


tjikkun at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tjikkun at xs4all.nl




------- Additional Comments From tjikkun at xs4all.nl  2006-05-12 00:28 EST -------
not a full review yet but some points you need to improve:

- Package does not follow Fedora's package naming guildlines
  (wiki: PackageNamingGuidelines)
  release should be 1, 2, 3, not 2.0
- BuildRequires: desktop-file-utils is missing

%define	desktop_vendor planetccrma
- desktop_vendor is fedora :)
- add to desktop-file-install: --add-category X-Fedora

# distros with 2.4.x kernels should use jackstart as the default
%{?fc1:%define usejackstart 1}
%{?rh9:%define usejackstart 1}
- this define can go since extras doesn't go that far back

-just use rm istead of %__rm macro

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.