[Bug 179237] Review Request: swaks - A command-line SMTP transaction tester

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swaks - A command-line SMTP transaction tester


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179237


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2006-05-12 09:57 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is GPL, matches spec
- spec file written in English and is legible
- source matches upstream
- package builds OK on FC5 and in mock for rawhide (i386)
- no explicit BR's needed nor present
- no locales, libraries, sub-packages, or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- package appears to work OK
- no scriptlets

Notes:

  NTLM Auth requires Authen::NTLM from the NTLM perl distribution,
  which does not (despite what the first sentence of the license terms
  says) appear to be free software and is hence unlikely to get packaged
  for Extras.

  Digest-MD5 Auth requires Authen::DigestMD5, which will be available in
  Extras shortly after someone approves Bug #191494 (hint ;-) )

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.