[Bug 191434] Review Request: xarchon - Arcade board game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xarchon - Arcade board game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |wart at kobold.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-05-12 14:27 EST -------
MUST
====
 * rpmlint output clean
 * Sources match upstream
   491dea5b4e61ed13cd988d1c184a8ef0  xarchon-0.50.tar.gz
 * GPL license ok, license file included
 * Package and spec file named appropriately
 * .desktop file installed correctly
 * RPM_BUILD_ROOT cleaned appropriately
 * spec file is legible and in Am. English
 * No locales  * No shared libs
 * No -devel subpackage needed
 * No -docs subpackage needed
 * Not relocatable
 * Owns all directories that it creates
 * Builds fine in mock on FC-4-i386

MUSTFIX
=======
 * Macro use isn't consistent.  'xarchon' is used in some places, while
   %{name} is used in others.

SHOULD
======
 * Don't bother including the NEWS file, it just tells the user to read
the ChangeLog file.

 * Missing BR: libXpm-devel on FC-5.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.