[Bug 177827] Review Request: python-ctypes - Advanced Foreign Function Interface for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-ctypes - Advanced Foreign Function Interface for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177827


toshio at tiki-lounge.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From toshio at tiki-lounge.com  2006-05-13 02:08 EST -------
APPROVED

SHA1SUM:
f7a7efac9246e3195a6fdb39a10d84d5ed6ff6e6  python-ctypes-0.9.9.6-1.src.rpm
831a731eebf8950a3dd3eb4cc18dbde8c7a859f5  ctypes-0.9.9.6.tar.gz
20edf3c22969a49e6f0bdff9f321e303fa4928e7  python-ctypes.spec

Informational:
* Note that the CFLAGS=$RPM_OPT_FLAGS definition doesn't seem to do anything
  for this package.  There's no harm in having it but the CFLAGS are
  actually being pulled in from python, not from the environment.

Good:
* All review guidelines passed.  Highlights follow:
* rpmlint has no output.
* python-ctypes conforms to the naming guidelines.
* License is MIT and included.
* The spec file is clear and legible.
* Source matches upstream.
* Builds on x86_64.
* Permissions set properly on all files.
* No extraneous directories; no unowned files or directories.
* Builds in mock.
* Runs through its test suite on x86_64.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.