[Bug 190040] Review Request: hydrogen - Advanced drum machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hydrogen - Advanced drum machine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190040


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.michael at gmx.net
OtherBugsDependingO|177841                      |
              nThis|                            |




------- Additional Comments From bugs.michael at gmx.net  2006-05-13 17:41 EST -------
[wrt 0.9.3-2]

* FE-NEEDSPONSOR blocker bug is for new contributors who don't have CVS
access yet. You don't belong to that group anymore.

* Fails to build (FC5), due to a hardcoded -lxml2 in configure{.in}.

/usr/bin/ld: cannot find -lxml2
collect2: ld returned 1 exit status

Missing:  BuildRequires: libxml2-devel

* From the build log:

| --- Checking for PortAudio -------------------------------------
| checking whether PORTAUDIOPATH environment variable is set... 
| PORTAUDIOPATH is not set. No PortAudio support.
| -----------------------------------------------------------------

PortAudio is available in Extras. Should it be enabled?

* rpmlint hydrogen-0.9.3-2.i386.rpm 
E: hydrogen shared-lib-without-dependency-information
/usr/lib/hydrogen/plugins/wasp_noisifier.so
E: hydrogen shared-lib-without-dependency-information
/usr/lib/hydrogen/plugins/wasp_booster.so
E: hydrogen shared-lib-without-dependency-information
/usr/lib/hydrogen/plugins/wasp_xshaper.so
E: hydrogen script-without-shellbang /usr/share/applications/hydrogen.desktop

The first three are safe to ignore. The latter is not. .desktop file is
executable. The review guidelines say it must be installed with
desktop-file-install.

* The explicit Requires on package names are not good. Kill them and
rely on rpmbuild's automatic dependencies on SONAMES.

* The hardcoded Qt version is not good. Source /etc/profile.d/qt.sh
which sets QTDIR correctly. Further, since many Qt configure checks
fail due to multilib locations, set QTLIB/QTINC like this:

--- hydrogen.spec.orig  2006-05-13 18:31:34.000000000 +0200
+++ hydrogen.spec       2006-05-13 22:58:46.000000000 +0200
@@ -11,8 +11,6 @@
 
 BuildRequires: flac-devel jack-audio-connection-kit-devel liblrdf-devel
 BuildRequires: qt-devel libsndfile-devel alsa-lib-devel
-Requires:      flac jack-audio-connection-kit liblrdf
-Requires:      qt libsndfile alsa-lib
 
 %description
 Hydrogen is an advanced drum machine for GNU/Linux. It's main goal is
@@ -25,8 +23,10 @@
 sed --in-place -e 's:$(prefix)/lib:%{_libdir}:g' plugins/wasp/Makefile.in
 
 %build
-%configure QTDIR=%{_libdir}/qt-3.3
-%{__make} %{?_smp_mflags} QTDIR=%{_libdir}/qt-3.3
+unset QTDIR || : ; . /etc/profile.d/qt.sh
+export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
+%configure
+%{__make} %{?_smp_mflags}
 
 %install
 %{__rm} -rf $RPM_BUILD_ROOT


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.