[Bug 191553] Review Request: crossfire-maps - map files for the crossfire game server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crossfire-maps - map files for the crossfire game server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191553





------- Additional Comments From chris.stone at gmail.com  2006-05-15 20:10 EST -------
* rpmlint output
W: crossfire-maps no-documentation
W: crossfire-maps hidden-file-or-dir /usr/share/crossfire/maps/.emergency
W: crossfire-maps-devel no-documentation

- No documention warnings okay.
- .emergency file is okay I guess, rpmlint says to check if it's normal and
delete it if it's not.  The .emergency file looks like it's part of the world/
map stuff, but I cannot determine if it's needed.  I'm giving the benefit of the
doubt and saying it's needed.

* Package meets Package Naming Guidelines
* spec file match base package %{name}
* Package meets Package Guidelines
* Package licensed with open source license
* License matches crossfire license
* No license file in source package
* Spec file in American English
* Spec file legible
* Souces match upstream
265c4dfdbdedaa2c565ea831f5f74a0c  crossfire-1.9.0-1.maps.tar.gz
265c4dfdbdedaa2c565ea831f5f74a0c  crossfire-1.9.0-1.maps.tar.gz
* Package builds under mock for FC5 x86_64
* No BuildRequires needed
* Package does not use locales
* Package does not contain any shared libraries
* Package is not relocatable
* Package owns the directories it creates
* No duplicate files in %files
* All files have appropriate %defattr settings
* %clean section present
* Macro usage consistant
* Package contains permissible content
* Package does not contain large documentation to warrent a -doc package
* No files in %doc affect runtime
* Package does not contain headers or static libraries, or .pc files
* Package does not contain any .so files
* devel package contains fully versioned dependency on base package
* Package does not contain any .la files
* Package does not need a .desktop file
* Package does not own files or directories owned by other packages

*** APPROVED ***

Non-Blocking SHOULDs:
- SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
- SHOULD: Check hidden file .emergency to see if it is really required.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.